> -----Original Message-----
> From: Richard Sandiford [mailto:richard.sandif...@arm.com]
> Sent: Monday, April 27, 2020 3:51 PM
> To: Yangfei (Felix) <felix.y...@huawei.com>
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH PR94784] ICE: in simplify_vector_constructor, at tree-
> ssa-forwprop.c:2482
> 
> "Yangfei (Felix)" <felix.y...@huawei.com> writes:
> > Hi,
> >
> >     PR tree-optimization/94269
> >     * tree-ssa-math-opts.c (convert_plusminus_to_widen): Restrict
> > -   this
> > -   operation to single basic block.
> > +   this operation to single basic block.
> 
> Not wrong, but might as well leave the entry as-is.

OK.  Leave it there.

> >
> We don't need to fall back to constant comparisons here.
> We should assert for known_eq between the TYPE_VECTOR_SUBPARTS
> instead.
> 
> Same for the other assert.

Good suggestion.  Modified accordingly.

> LGTM otherwise, and sorry for the breakage.

Does the v2 patch look better?

Manually run the following three tests with runtest:
    gcc.target/aarch64/sve/acle/general/pr94683.c
    gcc.target/aarch64/sve/acle/general/pr94700.c
    gcc.dg/pr94784.c

Thanks for your help,
Felix

Attachment: pr94784-v2.diff
Description: pr94784-v2.diff

Reply via email to