On Sat, Apr 11, 2020 at 10:27 AM Linus König <l...@sig-st.de> wrote: > > Hi, > > Here is the patch with some of the null pointer tests removed. > > This is regression-tested. ChangeLog and test case are as in > https://gcc.gnu.org/pipermail/fortran/2020-April/054193.html .
Thanks. Sorry I missed the ChangeLog entry and tests in my previous email. Those look good. > The list of test cases that fail without the remaining NULL > check is below. Is this OK for trunk? Thank you for the test listing. I apologize for being pedantic, but the remaining NULL check is still superfluous. The check can be removed simply by moving the new code past the BT_CLASS and EXPR_VARIABLE checks, just before the loop, like in my previous diffs. The idea is that when array->expr_type is EXPR_VARIABLE, array->symtree is guaranteed not to be NULL. If this invariant was violated, there are at least five functions in simplify.c alone which would segfault, including simplify_bound, even with this patch. Therefore I prefer not to check array->symtree for NULL before the EXPR_VARIABLE test. With that change I will OK the patch. If you and the regression tests concur, I can commit for you. I believe this is appropriate for backporting to 8 and 9 as well. Thanks again for your work. --- Fritz
