Hi Richard,
Here is a discussion we did some time ago
https://gcc.gnu.org/pipermail/gcc/2019-January/227834.html
please see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88877 for more
info regarding the bug.

We incorporated below Jakub's suggestion in this patch.

Jakub wrote:
""
Yeah, all the callers of emit_library_call* would need to be changed to pass
triplets rtx, machine_mode, int/bool /*unsignedp*/, instead of just
rtx_mode_t pair.
Jakub
""

On Mon, Apr 6, 2020 at 2:47 PM Richard Biener <rguent...@suse.de> wrote:
>
> On Mon, 6 Apr 2020, kamlesh kumar wrote:
>
> > Segher,
> > Please provide your suggestion/thought on the fix.
>
> There is not a single line of explanation what the change does so what
> do you expect?
>
> Richard.
>
> > On Mon, Mar 23, 2020 at 8:16 PM kamlesh kumar <kamleshbha...@gmail.com> 
> > wrote:
> > >
> > > Attached patch fixes.
> > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88877.
> > > ChangeLog Entry.
> > >
> > > 2020-03-23  Kamlesh Kumar  <kamleshbha...@gmail.com>
> > >
> > >         * rtl.h : Defined Tuple for bundling rtx, mode and
> > > unsignedness default as 0
> > >         Added Extra argument (unsignedp) in emit_library_call and
> > > emit_library_call_value.
> > >         * except.c : Likewise.
> > >         * explow.c : Likewise.
> > >         * expmed.c : Likewise.
> > >         * expr.c : Likewise.
> > >         * optabs.c : Likewise.
> > >         * asan.c : Likewise.
> > >         * builtins.c : Likewise.
> > >         * calls.c : Likewise.
> > >         * cfgexpand.c : Likewise.
> > >         * config/aarch64/aarch64.c : Likewise.
> > >         * config/aarch64/aarch64.h : Likewise.
> > >         * config/aarch64/atomics.md : Likewise.
> > >         * config/alpha/alpha.c : Likewise.
> > >         * config/arc/arc.c : Likewise.
> > >         * config/arc/elf.h : Likewise.
> > >         * config/arc/linux.h : Likewise.
> > >         * config/arm/arm.c : Likewise.
> > >         * config/bfin/bfin.md : Likewise.
> > >         * config/c6x/c6x.c : Likewise.
> > >         * config/csky/csky.c : Likewise.
> > >         * config/frv/frv.c : Likewise.
> > >         * config/i386/i386-expand.c : Likewise.
> > >         * config/i386/i386.c : Likewise.
> > >         * config/ia64/ia64.c : Likewise.
> > >         * config/ia64/ia64.md : Likewise.
> > >         * config/m32r/m32r.c : Likewise.
> > >         * config/m68k/linux.h : Likewise.
> > >         * config/m68k/m68k.c : Likewise.
> > >         * config/microblaze/microblaze.c : Likewise.
> > >         * config/mips/mips.h : Likewise.
> > >         * config/mips/sdemtk.h : Likewise.
> > >         * config/nds32/nds32.h : Likewise.
> > >         * config/nios2/nios2.c : Likewise.
> > >         * config/or1k/or1k.c : Likewise.
> > >         * config/pa/pa.c : Likewise.
> > >         * config/pa/pa.md : Likewise.
> > >         * config/pru/pru.c : Likewise.
> > >         * config/riscv/riscv.h : Likewise.
> > >         * config/riscv/riscv.md : Likewise.
> > >         * config/rl78/rl78.c : Likewise.
> > >         * config/rs6000/rs6000-string.c : Likewise.
> > >         * config/rs6000/rs6000.c : Likewise.
> > >         * config/rs6000/rs6000.md : Likewise.
> > >         * config/rs6000/vsx.md : Likewise.
> > >         * config/sh/sh.c : Likewise.
> > >         * config/sparc/sparc.c : Likewise.
> > >         * config/tilegx/tilegx.c : Likewise.
> > >         * config/tilepro/tilepro.c : Likewise.
> > >         * config/visium/visium.c : Likewise.
> > >         * config/xtensa/xtensa.c : Likewise.
> > >         * testsuite/gcc.target/powerpc/pr88877.c : Newtest
> >
>
> --
> Richard Biener <rguent...@suse.de>
> SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg,
> Germany; GF: Felix Imendörffer; HRB 36809 (AG Nuernberg)

Reply via email to