David Malcolm <dmalc...@redhat.com> writes: > On Wed, 2020-03-18 at 23:51 +0100, Andrea Corallo wrote: > Please add the new test to the header in its alphabetical location, > i.e. between: > > /* test-vector-types.cc: We don't use this, since it's C++. */ > > and > > /* test-volatile.c */ > > An entry also needs to be added to the "testcases" array at the end of > the header (again, in the alphabetical-sorted location).
I tried adding the test into the "testcases" array but this makes the threads test failing. I think this has nothing to do with this patch and happen just because this test does not define any code. Infact I see the same happening just adding "test-empty.c" to the "testcases" array on the current master. The error is not very reproducible, I tried a run under valgrind but have found nothing so far :/ Dave do you recall if there was a specific reason not to have "test-empty.c" into the "testcases" array? Andrea
