On Thu, 2020-03-26 at 17:03 -0500, Segher Boessenkool wrote:
> Hi!
> 
> On Tue, Mar 24, 2020 at 01:26:25PM -0500, will schmidt wrote:
> >   Update existing testcase powerpc/bswap64-4.c to
> > reflect that we generate ldbrx and stdbrx instructions
> > for newer cpu targets.  This is in contrast to the 
> > pair of lwbrx and stwbrx instructions that are
> > generated with older cpu targets.
> 
> So, this has always been broken for p7 and later?  Or what changed?

I believe this test has always been broken.  It gets called out as
UNSUPPORTED in most of our environments, (requires -m32) so we
typically don't see it.   I noticed it during a test result review of
one of the other patches.

P8BE before:
FAIL: gcc.target/powerpc/bswap64-4.c scan-assembler-times lwbrx 2
P8BE with patch:
PASS: gcc.target/powerpc/bswap64-4.c scan-assembler-times ldbrx 1

P8LE  (and basically everywhere other environment I have handy)
UNSUPPORTED: gcc.target/powerpc/bswap64-4.c

> 
> Okay for trunk.  Thanks!

thanks    
-Will

> 
> 
> Segher
> 
> 
> > testsuite/
> >     * gcc.target/powerpc/bswap64-4.c: Update scan-assembler
> >     expected results.

Reply via email to