On Mon, Mar 23, 2020 at 04:09:52PM +0100, Martin Liška wrote:
> 2020-03-17 Martin Liska <mli...@suse.cz>
>
> PR target/93274 PR lto/94271
> * gcc.target/i386/pr81213-2.c: New test.
> * gcc.target/i386/pr81213.c: Add additional source.
> * gcc.dg/lto/pr94271_0.c: New test.
> * gcc.dg/lto/pr94271_1.c: New test.
I've noticed this test now has UNRESOLVED cases:
+UNRESOLVED: gcc.target/i386/pr81213.c scan-assembler \\t.globl\\tfoo
+UNRESOLVED: gcc.target/i386/pr81213.c scan-assembler foo.resolver:
+UNRESOLVED: gcc.target/i386/pr81213.c scan-assembler foo\\\\,
@gnu_indirect_function
1) shall the test start with PR ipa/81214 reference when it is PR ipa/81213
test?
2) the UNRESOLVED cases can be fixed e.g. through:
--- gcc/testsuite/gcc.target/i386/pr81213.c.jj 2020-03-25 11:39:07.605865708
+0100
+++ gcc/testsuite/gcc.target/i386/pr81213.c 2020-03-26 10:13:23.616527400
+0100
@@ -1,6 +1,7 @@
/* PR ipa/81214. */
/* { dg-do run } */
/* { dg-require-ifunc "" } */
+/* { dg-options "-save-temps" } */
/* { dg-additional-sources "pr81213-2.c" } */
int bar();
3) but then one ends up with
FAIL: gcc.target/i386/pr81213.c scan-assembler \t.globl\tfoo
Do you want to change that to scan-assembler-not now that you don't want to
make foo public, or something else?
> --- a/gcc/testsuite/gcc.target/i386/pr81213.c
> +++ b/gcc/testsuite/gcc.target/i386/pr81213.c
> @@ -1,6 +1,9 @@
> /* PR ipa/81214. */
> -/* { dg-do compile } */
> +/* { dg-do run } */
> /* { dg-require-ifunc "" } */
> +/* { dg-additional-sources "pr81213-2.c" } */
> +
> +int bar();
>
> __attribute__((target_clones("avx","arch=slm","arch=core-avx2","default")))
> static int
> @@ -11,7 +14,7 @@ foo ()
>
> int main()
> {
> - return foo();
> + return foo() + bar();
> }
>
> /* { dg-final { scan-assembler "\t.globl\tfoo" } } */
> --
> 2.25.1
>
Jakub
