On 3/21/20 8:03 AM, Richard Biener wrote:
OK for the trunk?
It should be TYPE_ALIGN (type). OK with that change.
I am confused. The patch has:
+ SET_DECL_ALIGN (link_ptr_var, TYPE_ALIGN (ptr_type_node));
which looks correct and to uses already TYPE_ALIGN?!?
Note this fails to honor target bits so it might be better to lay out the decl
properly?
However, that's a good point. Let's do it properly by calling layout_decl
— indirectly, by calling build_decl.
OK?
Tobias
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander
Walter
Set proper DECL_ALIGN in offload_handle_link_vars (PR94233)
gcc/lto/
PR middle-end/94233
* lto.c (offload_handle_link_vars): Cleanup; call
build_decl to ensure alignment is set.
diff --git a/gcc/lto/lto.c b/gcc/lto/lto.c
index 39bb5f45c95..467b922eedf 100644
--- a/gcc/lto/lto.c
+++ b/gcc/lto/lto.c
@@ -561,18 +561,14 @@ offload_handle_link_vars (void)
DECL_ATTRIBUTES (var->decl)))
{
tree type = build_pointer_type (TREE_TYPE (var->decl));
- tree link_ptr_var = make_node (VAR_DECL);
- TREE_TYPE (link_ptr_var) = type;
- TREE_USED (link_ptr_var) = 1;
- TREE_STATIC (link_ptr_var) = 1;
- SET_DECL_MODE (link_ptr_var, TYPE_MODE (type));
- DECL_SIZE (link_ptr_var) = TYPE_SIZE (type);
- DECL_SIZE_UNIT (link_ptr_var) = TYPE_SIZE_UNIT (type);
- DECL_ARTIFICIAL (link_ptr_var) = 1;
tree var_name = DECL_ASSEMBLER_NAME (var->decl);
char *new_name
= ACONCAT ((IDENTIFIER_POINTER (var_name), "_linkptr", NULL));
- DECL_NAME (link_ptr_var) = get_identifier (new_name);
+ tree link_ptr_var = build_decl (UNKNOWN_LOCATION, VAR_DECL,
+ get_identifier (new_name), type);
+ TREE_USED (link_ptr_var) = 1;
+ TREE_STATIC (link_ptr_var) = 1;
+ DECL_ARTIFICIAL (link_ptr_var) = 1;
SET_DECL_ASSEMBLER_NAME (link_ptr_var, DECL_NAME (link_ptr_var));
SET_DECL_VALUE_EXPR (var->decl, build_simple_mem_ref (link_ptr_var));
DECL_HAS_VALUE_EXPR_P (var->decl) = 1;
