On 3/20/20 4:43 PM, Jakub Jelinek wrote:
On Fri, Mar 20, 2020 at 04:40:17PM +0100, Martin Liška wrote:
Thank you very much for the feedback, it was useful. I realized that
the patch made a huge code bloat (mainly because of the string constants
and the fact that it didn't end quickly (with an internal_error).
The loop is here not possible because we compare struct fields.
Are you sure? I mean, you could have a loop over cl_options array which
contains the needed offsetof values and also the types.
Ok, it would be possible, but if you take a look at options-save.c there's no
function that will leverage that. It's a generated code so I guess we can
live with that?
Martin
Jakub
