On Tue, 2020-03-17 at 14:27 +0100, Christophe Lyon wrote:
>
> > Jeff pointed out off-list that using:
> >
> > N: ... /* { dg-error {...} } */
> > N+1: /* { dg-error {...} "" { target *-*-* } .-1 } */
> >
> > led to two identical test names for line N. This was causing the
> > results to fluctuate when using contrib/compare_tests (which I admit
> > I don't do, so hadn't noticed). Your patch fixes the cases that
> > mattered, but for future-proofing reasons, this patch adds proper
> > test names for the remaining instances.
> >
>
> Thanks.
>
> Just checked, there are many more testcases with duplicate "names"
> (266 under gcc.target/aarch64 only) :-(
Yea. It's a fairly common issue and not immediately obvious unless someone is
using the compare_tests script.
I think when this came up with some of Martin Sebor's work we agreed to fault in
fixes to the existing tests, so I think that would apply here as well.
Jeff
>
