On Thu, 12 Mar 2020, Jakub Jelinek wrote:
> Hi!
>
> When looking into PR94134, I've noticed bugs in the
> ASM_OUTPUT_ALIGNED_DECL_LOCAL documentation. varasm.c has:
> #if defined ASM_OUTPUT_ALIGNED_DECL_LOCAL
> unsigned int align = symtab_node::get (decl)->definition_alignment ();
> ASM_OUTPUT_ALIGNED_DECL_LOCAL (asm_out_file, decl, name,
> size, align);
> return true;
> #elif defined ASM_OUTPUT_ALIGNED_LOCAL
> unsigned int align = symtab_node::get (decl)->definition_alignment ();
> ASM_OUTPUT_ALIGNED_LOCAL (asm_out_file, name, size, align);
> return true;
> #else
> ASM_OUTPUT_LOCAL (asm_out_file, name, size, rounded);
> return false;
> #endif
> and the ASM_OUTPUT_ALIGNED_LOCAL documentation properly mentions:
> Like @code{ASM_OUTPUT_LOCAL} and mentions the same macro in another place.
> The ASM_OUTPUT_ALIGNED_DECL_LOCAL description mentions non-existing macros
> ASM_OUTPUT_ALIGNED_DECL and ASM_OUTPUT_DECL instead of the right ones
> ASM_OUTPUT_ALIGNED_LOCAL and ASM_OUTPUT_LOCAL.
>
> Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for
> trunk?
OK
> 2020-03-12 Jakub Jelinek <ja...@redhat.com>
>
> * doc/tm.texi.in (ASM_OUTPUT_ALIGNED_DECL_LOCAL): Change
> ASM_OUTPUT_ALIGNED_DECL in description to ASM_OUTPUT_ALIGNED_LOCAL
> and ASM_OUTPUT_DECL to ASM_OUTPUT_LOCAL.
> * doc/tm.texi: Regenerated.
>
> --- gcc/doc/tm.texi.in.jj 2020-01-12 11:54:36.555411266 +0100
> +++ gcc/doc/tm.texi.in 2020-03-11 15:25:47.794562267 +0100
> @@ -5410,11 +5410,11 @@ as the number of bits.
> @end defmac
>
> @defmac ASM_OUTPUT_ALIGNED_DECL_LOCAL (@var{stream}, @var{decl}, @var{name},
> @var{size}, @var{alignment})
> -Like @code{ASM_OUTPUT_ALIGNED_DECL} except that @var{decl} of the
> +Like @code{ASM_OUTPUT_ALIGNED_LOCAL} except that @var{decl} of the
> variable to be output, if there is one, or @code{NULL_TREE} if there
> is no corresponding variable. If you define this macro, GCC will use it
> -in place of both @code{ASM_OUTPUT_DECL} and
> -@code{ASM_OUTPUT_ALIGNED_DECL}. Define this macro when you need to see
> +in place of both @code{ASM_OUTPUT_LOCAL} and
> +@code{ASM_OUTPUT_ALIGNED_LOCAL}. Define this macro when you need to see
> the variable's decl in order to chose what to output.
> @end defmac
>
> --- gcc/doc/tm.texi.jj 2020-01-24 22:34:36.096644965 +0100
> +++ gcc/doc/tm.texi 2020-03-11 15:26:07.899268563 +0100
> @@ -8384,11 +8384,11 @@ as the number of bits.
> @end defmac
>
> @defmac ASM_OUTPUT_ALIGNED_DECL_LOCAL (@var{stream}, @var{decl}, @var{name},
> @var{size}, @var{alignment})
> -Like @code{ASM_OUTPUT_ALIGNED_DECL} except that @var{decl} of the
> +Like @code{ASM_OUTPUT_ALIGNED_LOCAL} except that @var{decl} of the
> variable to be output, if there is one, or @code{NULL_TREE} if there
> is no corresponding variable. If you define this macro, GCC will use it
> -in place of both @code{ASM_OUTPUT_DECL} and
> -@code{ASM_OUTPUT_ALIGNED_DECL}. Define this macro when you need to see
> +in place of both @code{ASM_OUTPUT_LOCAL} and
> +@code{ASM_OUTPUT_ALIGNED_LOCAL}. Define this macro when you need to see
> the variable's decl in order to chose what to output.
> @end defmac
>
>
> Jakub
>
>
--
Richard Biener <rguent...@suse.de>
SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg,
Germany; GF: Felix Imendörffer; HRB 36809 (AG Nuernberg)
