Re: [PATCH] libstdc++: Add a test that takes the split_view of a non-forward range

[Jonathan Wakely via Gcc-patches]

On 11/03/20 11:46 -0400, Patrick Palka wrote:

This adds a tests that verifies taking the split_view of a non-forward range
works correctly.  Doing so revealed a typo in one of _OuterIter's constructors.

Oops!

It also revealed that the default constructor of
__gnu_test::test_range::iterator misbehaves, because by delegating to
Iter<T>(nullptr, nullptr) we perform a null-pointer deref at runtime in
input_iterator_wrapper's constructor due to the ITERATOR_VERIFY check therein.

Oops for me this time.

Instead of delegating to this constructor it seems we can just inherit the
protected default constructor, which does not contain this ITERATOR_VERIFY
check.

Yep, that makes much more sense.

OK for master, thanks.