> -----Original Message----- > From: Eric Botcazou <ebotca...@adacore.com> > Sent: March 11, 2020 6:16 AM > To: Richard Wai <rich...@annexi-strayline.com> > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCHv2] Ada: gcc-interface: fixed assertion for aliased entities >
> > Thanks for the analysis and the fix. This has indeed apparently never worked > and could be the origin of a few Ada PRs in Bugzilla, although I didn't really > check that. The patch is obviously very safe so I have installed it on the > mainline and the 9 branch (after slightly trimming down the comment) with > the following ChangeLogs (I forgot to say that we require them too): > > 2020-03-11 Richard Wai <rich...@annexi-strayline.com> > > * gcc-interface/decl.c (gnat_to_gnu_entity): Also test Is_Public on > the Alias of the entitiy, if it is present, in the main assertion. > > 2020-03-11 Richard Wai <rich...@annexi-strayline.com> > > * gnat.dg/subpools1.adb: New test. > > > [The next time please send the patch and the testcase as attachments > instead, they apparently have been mangled by your mailer.] > Thanks for this; all points noted! Richard Wai ANNEXI-STRAYLINE