On Thu, 5 Mar 2020 at 16:49, Jeff Law <l...@redhat.com> wrote:
>
> On Mon, 2020-03-02 at 16:40 +0000, Richard Earnshaw (lists) wrote:
> > On 02/03/2020 15:46, Jeff Law wrote:
> > > More minor fallout from Vlad's IRA changes.
> > >
> > > Previously this test used r3 to hold a value across a call (it's an ipa-ra
> > > test). After Vlad's changes we're using r1 instead.
> > >
> > > This patch makes the obvious change to pattern we can for which should
> > > bring
> > > the test back to a passing status.
> > >
> > > There's a note about r3 being special on thumb1 and the pattern check is
> > > skipped for thumb1. That special casing my not be necessary anymore -- I
> > > leave
> > > that to the ARM maintainers to resolve one way or the other.
> > >
> > > Committing on the trunk momentarily.
> > >
> > > jeff
> > >
> >
> > Any of r1, r2, r3 could be chosen for the 'save' register, so why not
> > put that in the regexp?
> >
> > Something like:
> >
> > +/* { dg-final { scan-assembler-times "mov\tr[123], r0" 1 { target { !
> > arm_thumb1 } } } } */
> >
> > And then we are future-proof.
> Pushed to the trunk. Thanks for the suggestion.
>
Hi,
I've just pushed a fix for the obvious typo: [] need to be escaped:
-/* { dg-final { scan-assembler-times "mov\tr[123], r0" 1 { target { !
arm_thumb1 } } } } */
+/* { dg-final { scan-assembler-times "mov\tr\[123\], r0" 1 { target {
! arm_thumb1 } } } } */
Christophe
> jeff
>
