Hello JunMa,
JunMa <ju...@linux.alibaba.com> wrote:
Ping
Thanks for your patch(es) and I am sorry this has taken some time to review.
(right now, we’re trying to ensure that we have the latest standard
represented in
GCC10, so updating to n4849).
在 2020/2/27 上午10:17, JunMa 写道:
在 2020/2/11 上午10:50, JunMa 写道:
Hi
kindly ping~
Regards
JunMa
Hi
As title. in maybe_promote_captured_temps, we promote captured
temporaries
and co_await_expr into a new BIND_EXPR. As the BIND_EXPR contains
co_await_expr and maybe other function calls, the side effects flag
should
be set.
This patch fix one mismatch in cppcoro, the testcase comes from cppcoro
and is reduced by creduce.
With the following test conditions;
r10-7040-ga2ec7c4aafbcd517
+ the two approved patches by Bin Cheng applied.
1/ the test case in this patch (lambda-10-co-await-lambda.C) fails both with
and without the patch.
2/ the patch regresses one of my local testcases.
So, it appears that the testcase might show a bug - but the fix is not the
right one for current trunk?
Please could you re-check ?
thanks
Iain
