On Wed, Mar 04, 2020 at 12:53:58PM +0100, Martin Liška wrote:
> Hi.
> 
> I've noticed during working on VEC_COND_EXPR, that code added in
> r10-2910-g9151048d854e352a9b83b771c6711b8221c73f7e is not executed.
> It's also seen on our LCOV instance:
> https://users.suse.com/~mliska/lcov/gcc/optabs.c.gcov.html
> line 5889.
> 
> It started with the revision where we changed default to -fno-common.
> 
> Ready for trunk?

Wouldn't it be better to add pr91623-2.c testcase that would #include
this one and have the additional -fcommon, so that we test both -fcommon and
default behavior?
If you think it is completely unnecessary, just go ahead with your patch.

        Jakub

Reply via email to