On Tue, Feb 18, 2020 at 3:00 PM Martin Liška <mli...@suse.cz> wrote: > > On 2/18/20 11:19 AM, Richard Biener wrote: > > On Mon, Feb 17, 2020 at 4:21 PM Martin Liška <mli...@suse.cz> wrote: > >> > >> Hi. > >> > >> The patch is extension of 446096148ca9775cb56f9ee924fa283babcd0b76 commit > >> where we need to handle FIX_TRUNC_EXPR in compare_gimple_assign. > >> > >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > >> > >> Ready to be installed? > > > > There's also FLOAT_EXPR. > > > > I wonder why you can ever disregard comparing the types of the LHS? Yes, > > comparing is most of the time redundant but OTOH comparing the LHS > > types would be enough for all SSA defs and then you can elide comparing > > of SSA use types in way more cases?! > > All right, let's compare LHS types for all gimple_assigns. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed?
OK. > Thanks, > Martin > > > > >> Thanks, > >> Martin > >> > >> gcc/ChangeLog: > >> > >> 2020-02-17 Martin Liska <mli...@suse.cz> > >> > >> PR ipa/92518 > >> * ipa-icf-gimple.c (func_checker::compare_gimple_assign): > >> Consider also FIX_TRUNC_EXPR. > >> --- > >> gcc/ipa-icf-gimple.c | 4 +++- > >> 1 file changed, 3 insertions(+), 1 deletion(-) > >> > >> >
