Hi!
On Thu, Feb 13, 2020 at 04:41:03PM -0600, will schmidt wrote:
> The code generated by this test changed shortly after
> this test was committed, and we didn't get back to
> updating the scan-assembler statements to match.
> Until now.
Progress! :-)
Just some nits:
> [testsuite]
> * gcc.target/powerpc/fold-vec-extract-longlong.p8.c: Correct expected
> insns.
That line is too long.
> +// P8 (LE) variables: addi,xxpermdi,mr,stxvd2x|sxxvd4x,rldicl,sldi,ldx,blr
s/sxx/stx/
> -/* { dg-final { scan-assembler-times {\mmfvsrd\M} 6 { target lp64 } } } */
> -/* { dg-final { scan-assembler-times {\mmtvsrd\M} 3 { target lp64 } } } */
> +/* { dg-final { scan-assembler-times {\mmfvsrd\M} 3 { target lp64 } } } */
Why drop the mtvsrd check?
> -/* { dg-final { scan-assembler-times {\mxxpermdi\M} 6 { target { be && lp64
> } } } } */
Just like this one. Do they match 0 times now? Please keep the entry
then, but for 0 times?
Okay for trunk with that taken care of whichever way. Thanks!
Segher
