On Sun, Feb 09, 2020 at 09:15:46PM +0100, Toon Moene wrote: > On 2/6/20 9:01 PM, David Malcolm wrote: > > > PR analyzer/93405 reports an ICE when attempting to use -fanalyzer on > > certain gfortran code. The second patch in this kit fixes that, but > > in the meantime I need somewhere to put regression tests for -fanalyzer > > with gfortran. > > > > This patch adds a gfortran.dg/analyzer subdirectory with an analyzer.exp, > > setting DEFAULT_FFLAGS on the tests run within it. > > I have seen no objections against this proposal, so please go ahead. >
Perhaps, there are no objections because the people who contribute patches and provide reviews for gfortran have twindled to 1 or 2 people with sporadic available time. Did you actually review the proposed changes? If not, how can you rubber stamp this commit? You have a total of 12 ChangeLog entries over 18 years with the last occurring in 2011, and I do not recall you ever reviewing a patch. Finally, trunk is in stage 4 (regression fixes & docs only). This does not look like either. If I bootstrap gcc with fortran % mkdir obj % ../gcc/configure --prefix=$HOME/work --enable-languages=c,fortran \ --enable-bootstrap --enable-checking=yes % gmake bootstrap and then do % cd gcc % gmake check-fortran are these analyzer testcases built/executed? Do all architectures that support gfortran also support the analyzer infrastructure? -- Steve
