Hi Andrew, I just saw your patch here: https://gcc.gnu.org/ml/gcc-patches/2020-01/msg01474.html Re: [PATCH] gcc: Add new configure options to allow static libraries to be selected
Note: the artefacts in my patch below seem to be a missing re-generated gcc/configure from your patch? Is that right? I did not notice any problem from this, does this work for you this way? And, is it the right thing to push those changes along this patch, or do you want to take care of this by yourself? Thanks Bernd. On 1/31/20 5:58 PM, Bernd Edlinger wrote: > Hi, > > this is patch is heavily based on David's original patch here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01409.html > > and addresses Jakub's review comments here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01412.html > > So I hope you don't mind, when I pick up this patch since there > was not much activity recently on this issue, so I assumed you > would appreciate some help. > > I will try to improve the patch a bit, and hope you are gonna like > it. I agree that this feature is fine, and should be enabled by > default, and just if it is positively clear that it won't work, > disabled in the auto mode. > > Also as requested by Jakub this tries to be more compatible to > GCC_COLORS define, and adds the capability to switch between ST > and BEL string termination and also have a way to disable urls > even with -fdiagnostics-urls=always (like GCC_COLORS= disables colors). > > In addition to that I propose to use GCC_URLS and if that > is not defined use TERM_URLS to control that feature for > all applications willing to support that. > > Since I have seen much garbage from the URLs in the xfce4-terminal 0.6.3 > admittedly an old Ubuntu installation, but still in LTS status, > and no attempt from the xfc4-terminal to _ever_ implement URLs, I would > like to detect the xfce4-terminal, and use that in auto mode > to switch off the URLs feature, since in best case the URLs will > just be ignored, but can and will often create garbage on the screen. > > Likewise on MinGW, since the windows 10 cmd prompt does at best > ignore the URLs, but windows terminal and windows 7 cmd prompt > print garbage when URLs are output. > > I have one question though, regarding the autoconf version that > we use, it is autoconf-2.69, right, at least that is what I read in > gcc/doc/install.texi? > > I don't understand why the generated configure has additional > changes than what is changed in configure.ac. Should I commit the > generated version as is, or use a different autoconf version? > > > Bootstrapped and reg-tested on x86_64-pc-linux-gnu. > Is it OK for trunk? > > > Thanks > Benrd. >
