On Mon, Jan 20, 2020 at 05:10:55PM -0600, Segher Boessenkool wrote:
> On Mon, Jan 20, 2020 at 11:52:55PM +0100, Jakub Jelinek wrote:
> > PR target/93073
> > * config/rs6000/rs6000.c (rs6000_emit_cmove): Punt for compare_mode
> > other than SFmode or DFmode.
>
> "If using fsel, punt for..." etc.
Ack.
> > + /* Don't allow compare_mode other than SFmode or DFmode, for others there
> > + is no fsel instruction. */
> > + if (compare_mode != SFmode && compare_mode != DFmode)
> > + return 0;
>
> And move this a bit later, to right after
> /* At this point we know we can use fsel. */
> please?
I can move it if you want (not sure what is the gain, because the mode
check is cheaper than some of the other checks in there), but don't
understand why to after that comment rather than say immediately before that
comment. Because with TFmode or KFmode we know we can't use fsel, and
the comment seems to mark the point at which we have decided we can use the
instruction and just prepare arguments for it.
Jakub
