On Sun, Dec 15, 2019 at 07:11:25PM +0100, Thomas Koenig wrote:
> Am 10.12.19 um 22:22 schrieb Thomas Koenig:
> > Steve made an excellent suggestion: -finline-arg-packing .
> >
> > So, OK with that change?
>
> In other words, is
>
> https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00485.html
>
> OK with renaming the option to -finline-arg-packing ?
This patch broke:
+FAIL: compiler driver --help=fortran option(s): "^ +-.*[^:.]\$" absent from
output: " -finline-arg-packing Perform argument packing inline"
That test verifies that the help texts of all options are terminated
with dot or semicolon.
Fixed thusly, tested with make check-gcc RUNTESTFLAGS=help.exp.
I've additionally noticed you've swapped the two ChangeLog entries,
testsuite/ one went into fortran/ and vice versa, swapped that too
(and that is the reason why I'm posting exactly what I've committed
as obvious, rather than ChangeLog entry before patch + patch).
--- fortran/lang.opt (revision 279686)
+++ fortran/lang.opt (revision 279687)
@@ -649,7 +649,7 @@ Enum(gfc_init_local_real) String(-inf) V
finline-arg-packing
Fortran Var(flag_inline_arg_packing) Init(-1)
--finline-arg-packing Perform argument packing inline
+-finline-arg-packing Perform argument packing inline.
finline-matmul-limit=
Fortran RejectNegative Joined UInteger Var(flag_inline_matmul_limit) Init(-1)
--- testsuite/ChangeLog (revision 279686)
+++ testsuite/ChangeLog (revision 279687)
@@ -51,12 +51,7 @@
PR middle-end/91512
PR fortran/92738
- * invoke.texi: Document -finline-arg-packing.
- * lang.opt: Add -finline-arg-packing.
- * options.c (gfc_post_options): Handle -finline-arg-packing.
- * trans-array.c (gfc_conv_array_parameter): Use
- flag_inline_arg_packing instead of checking for optimize and
- optimize_size.
+ * gfortran.dg/inline_pack_25.f90: New test.
2019-12-20 Tobias Burnus <tob...@codesourcery.com>
--- fortran/ChangeLog (revision 279686)
+++ fortran/ChangeLog (revision 279687)
@@ -1,8 +1,19 @@
+2019-12-20 Jakub Jelinek <ja...@redhat.com>
+
+ PR middle-end/91512
+ PR fortran/92738
+ * lang.opt (-finline-arg-packing): Add trailing dot to help text.
+
2019-12-20 Thomas Koenig <tkoe...@gcc.gnu.org>
PR middle-end/91512
PR fortran/92738
- * gfortran.dg/inline_pack_25.f90: New test.
+ * invoke.texi: Document -finline-arg-packing.
+ * lang.opt: Add -finline-arg-packing.
+ * options.c (gfc_post_options): Handle -finline-arg-packing.
+ * trans-array.c (gfc_conv_array_parameter): Use
+ flag_inline_arg_packing instead of checking for optimize and
+ optimize_size.
2019-12-20 Tobias Burnus <tob...@codesourcery.com>
Jakub
