On Thu, Dec 08, 2011 at 03:11:44PM +0100, Richard Guenther wrote:
> >> > Another nit (sorry I didn't see this before :-/) :
> >> >
> >> > > + expr->ops.phi.args = (tree *) xcalloc (nargs, sizeof (tree));
> >> >
> >> > This leaks, because you missed to add freeing to free_expr_hash_elt.
> >> > Apart from that looks good to me, but I can't approve.
> >> >
> >>
> >> /facered :(
> >>
> >> Thanks. Will fix...
> >>
> >> Bill
> >
> > Richard -- OK with this change?
>
> Yes.
But please use:
expr->ops.phi.args = XCNEWVEC (tree, nargs);
instead of the above.
Jakub
