On Tue, 2019-12-10 at 09:36 -0500, Lewis Hyatt wrote:
> On Mon, Dec 9, 2019 at 4:58 PM David Malcolm <dmalc...@redhat.com>
> wrote:
> > On Thu, 2019-10-10 at 16:27 -0400, Lewis Hyatt wrote:
> > > Hello-
> > > 
> > > This short patch addresses
> > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91843
> > > by adding the needed multibyte awareness to pretty-print.c.
> > > Together with my other patch awaiting review
> > > (https://gcc.gnu.org/ml/gcc-patches/2019-09/msg01627.html), this
> > > fixes all
> > > issues that I am aware of regarding printing diagnostics with
> > > multibyte
> > > characters in UTF-8 locales. Would you please have a look and see
> > > if
> > > it's OK?
> > > Thanks very much.
> > > 
> > > bootstrapped and tested on x86-64 Linux, all test results were
> > > identical before
> > > and after:
> > > 34 XPASS
> > > 109 FAIL
> > > 1490 XFAIL
> > > 9470 UNSUPPORTED
> > > 332971 PASS
> > > 
> > > -Lewis
> > 
> > Patch looks good to me.
> > 
> > Do you want SVN commit access, as per:
> >   https://www.gnu.org/software/gcc/svnwrite.html
> > ?
> > 
> > I'm willing to sponsor you.
> > 
> > Dave
> > 
> 
> All set with the commit access, thank you. 

Excellent.

> I just wanted to double
> check that this patch is OK to go in.

Looks good to me.

Dave

Reply via email to