On Thu, Dec 8, 2011 at 2:19 AM, Andrew Pinski <pins...@gmail.com> wrote: > On Wed, Dec 7, 2011 at 5:07 PM, Han Shen <shen...@google.com> wrote: >> + /* Examine each basic block for address taking of local variables. */ > > I don't think you need to look at the basic blocks to figure out if a > local variable has its address taken. You can look through referenced > variables and see if it is a local variable and TREE_ADDRESSABLE is > set. This should speed up the code a lot. Though that might has some > false positives with arrays but that is ok because you are checking if > there are any arrays already anyways.
Indeed. Also your patch does not adhere to the GCC coding standards. For example all functions need toplevel comments documenting their purpose and their parameters. Richard. > Thanks, > Andrew Pinski
