On 01/12/11 11:09, Georg-Johann Lay wrote: > Richard Earnshaw wrote: >> On 29/11/11 09:42, Matthew Gretton-Dann wrote: >>> All, >>> >>> Whilst developing the Cortex-A15 integer pipeline patch it was noted >>> that the MD_INCLUDES variable in config/arm/t-arm has not been kept >>> up-to-date. >>> >>> The attached patch fixes this, and rearranges the list of md files into >>> alphabetical order. >>> >>> The list was generated using `ls -1 *.md | grep -v arm\\.md`. >>> >>> Tested by doing a arm-none-eabi build. >>> >>> Can someone please review, and if appropriate apply? >>> >>> Thanks, >>> >>> Matt >>> >>> gcc/ChangeLog: >>> 2011-11-29 Matthew Gretton-Dann <matthew.gretton-d...@arm.com> >>> >>> * config/arm/t-arm (MD_INCLUDES): Ensure all md files are >>> listed. >>> >> >> OK. >> >> R. > > Is each entry mandatory in that list? > > I thought gen-tools already arrange for great part of MD_INCLUDES? > > For example, after adding (include "avr-dimode.md") to avr.md, ./gcc/mddeps.mk > reads: > > MD_INCLUDES = \ > ../../../gcc.gnu.org/trunk/gcc/config/avr/predicates.md \ > ../../../gcc.gnu.org/trunk/gcc/config/avr/constraints.md \ > ../../../gcc.gnu.org/trunk/gcc/config/avr/avr-dimode.md > > ../../../gcc.gnu.org/trunk/gcc/config/avr/predicates.md: > > ../../../gcc.gnu.org/trunk/gcc/config/avr/constraints.md: > > ../../../gcc.gnu.org/trunk/gcc/config/avr/avr-dimode.md: > > so that maintaining such a list might be considerable easier. >
Indeed. I hadn't realised that that feature had been added since I first added that macro. It does indeed look as though the whole definition of MD_INCLUDES is now redundant. R.
