On Sat, Nov 16, 2019 at 10:34 PM Thomas Koenig <tkoe...@netcologne.de> wrote: > > Hello world, > > here is an update to the patch. > > I have now included variables where the user did not specify INTENT(IN) > by checking that the dummy variables to be replaced by temporaries > are not, indeed, assigned a value. This also includes being passed > as an actual argument to a non-INTENT(IN) dummy argument. > > Extending this led to being able to catch a few more bugs. > > I have addes one test case to check where the new temporaries are added. > > Regression-tested. The only change I see in the testsuite now is > > XPASS: gfortran.dg/goacc/kernels-loop-n.f95 -O scan-tree-dump-times > parloops1 "(?n)__attribute__\\(\\(oacc kernels parallelized, oacc > function \\(, , \\), oacc kernels, omp target entrypoint\\)\\)" 1
BTW, since this is done for the purpose of optimization, have you done testing on some suitable benchmark suite such as polyhedron, whether it a) generates any different code b) does it make it go faster? Is there a risk of performance regressions due to higher register pressure? -- Janne Blomqvist
