On Tue, 19 Nov 2019 at 11:35, Richard Henderson
<richard.hender...@linaro.org> wrote:
>
> I'm not sure what happened to v2. I can see it in my sent email, but it never
> made it to the mailing list, and possibly not to Richard E. either.
>
> So resending, with an extra testsuite fix for ilp32, spotted by Christophe.
>
> Re thumb1, rather than an ifdef in config/arm/aarch-common.c, as I did in v1,
> I
> am swapping out a targetm hook when changing into and out of thumb1 mode.
>
There were small problems in this patch, we I have fixed as obvious in r278487:
[testsuite][arm] Fix asm-flag-[45].c tests
In asm-flag-4.c, we need to use dg-message instead of dg-error because
we have to match "sorry, unimplemented:" rather than "error:". In
asm-flag-5.c, fix the dg-error syntax.
2019-11-20 Christophe Lyon <christophe.l...@linaro.org>
* gcc.target/arm/asm-flag-4.c: Replace dg-error with dg-message.
* gcc.target/arm/asm-flag-5.c: Add quotes around dg-error
messages.
Index: gcc/testsuite/gcc.target/arm/asm-flag-4.c
===================================================================
--- gcc/testsuite/gcc.target/arm/asm-flag-4.c (revision 278486)
+++ gcc/testsuite/gcc.target/arm/asm-flag-4.c (revision 278487)
@@ -9,5 +9,5 @@
void __attribute__((target("thumb"))) g(char *out)
{
- asm("" : "=@ccne"(out[0])); /* { dg-error asm flags not supported } */
+ asm("" : "=@ccne"(out[0])); /* { dg-message "asm flags not supported" } */
}
Index: gcc/testsuite/gcc.target/arm/asm-flag-5.c
===================================================================
--- gcc/testsuite/gcc.target/arm/asm-flag-5.c (revision 278486)
+++ gcc/testsuite/gcc.target/arm/asm-flag-5.c (revision 278487)
@@ -13,13 +13,13 @@
void f_f(void)
{
float x;
- asm("" : "=@cccc"(x)); /* { dg-error invalid type } */
+ asm("" : "=@cccc"(x)); /* { dg-error "invalid type" } */
}
void f_d(void)
{
double x;
- asm("" : "=@cccc"(x)); /* { dg-error invalid type } */
+ asm("" : "=@cccc"(x)); /* { dg-error "invalid type" } */
}
struct S { int x[3]; };
@@ -27,5 +27,5 @@
void f_S(void)
{
struct S x;
- asm("" : "=@cccc"(x)); /* { dg-error invalid type } */
+ asm("" : "=@cccc"(x)); /* { dg-error "invalid type" } */
}
>
> r~
>
>
