On Tue, Nov 5, 2019 at 4:31 PM Andrew MacLeod <amacl...@redhat.com> wrote: > > On 11/5/19 8:21 AM, Aldy Hernandez wrote: > > The base class for ranges is currently value_range_base, which is > > rather long and cumbersome. It also occurs more often than the > > derived class of value_range. To avoid confusion, and save typing, > > this patch does a global rename from value_range to value_range_equiv, > > and from value_range_base to value_range. > > > > This way, the base class is simply value_range, and the derived class > > is value_range_equiv which explicitly states what it does. > > > > OK? > > > > Aldy > > > > p.s. There are a few minor cleanups throughout... like moving some > > random variable definitions closer to their first use. I figured they > > were harmless while I was in the vicinity. > > I think this is reasonable. > > Long term expectation is that the equivalency bits may be subsumed in > other ways and we can do away with value_range_equiv derived class.. and > then everything will just be 'value_range'. Until such time, I think > value_range_equiv is also clearer
value_range_with_equiv is less misleading. Or why not [e]vrp_range? > > Approved. >
