On 11/4/19 5:23 PM, Aldy Hernandez wrote:
value_range_base::operator== was originally lifted from a world where
symbolics didn't exist (the ranger branch), but symbolics do exist in
mainline.
Although this isn't causing a problem yet, as soon as someone tries to
compare non numeric ranges, we'll die. Using operand_equal_p
simplifies the comparison code drastically.
I suppose if/when we get multiple sub-ranges in value_range_base,
we'll have to adapt this function again to compare things piece wise.
For now, let's keep things simple.
OK pending tests?
Oh, we brought over the multiple sub-range bits to value_range_base...
yeah we can remove that and just check for operand equality. we'll deal
with multiple subranges when thats a thing.
Is this any different than just calling value_range_base::equal_p()?
Andrew
