On Mon, 28 Oct 2019 at 16:03, Prathamesh Kulkarni <prathamesh.kulka...@linaro.org> wrote: > > On Mon, 28 Oct 2019 at 07:18, Richard Biener <richard.guent...@gmail.com> > wrote: > > > > On Fri, Oct 25, 2019 at 9:58 PM Prathamesh Kulkarni > > <prathamesh.kulka...@linaro.org> wrote: > > > > > > On Fri, 25 Oct 2019 at 13:19, Richard Biener <richard.guent...@gmail.com> > > > wrote: > > > > > > > > On Wed, Oct 23, 2019 at 11:45 PM Prathamesh Kulkarni > > > > <prathamesh.kulka...@linaro.org> wrote: > > > > > > > > > > Hi, > > > > > The attached patch tries to fix PR92163 by calling > > > > > gimple_purge_dead_eh_edges from ifcvt_local_dce if we need eh cleanup. > > > > > Does it look OK ? > > > > > > > > Hmm. I think it shows an issue with the return value of > > > > remove_stmt_form_eh_lp > > > > which is true if the LP index is -1 (externally throwing). We don't > > > > need to purge > > > > any edges in that case. That is, if-conversion should never need to > > > > do EH purging > > > > since that would be wrong-code. > > > > > > > > As of the segfault can you please instead either pass down > > > > need_eh_cleanup > > > > as function parameter (and NULL from ifcvt) or use the return value in > > > > DSE > > > > to set the bit in the caller. > > > Hi Richard, > > > Thanks for the suggestions, does the attached patch look OK ? > > > Bootstrap+test in progress on x86_64-unknown-linux-gnu. > > > > OK. > Thanks, committed to trunk in r277525 after bootstrap+test on > x86_64-unknown-linux-gnu. >
Hi Prathamesh, There's a problem with the new test you added: if uses -fopenacc which is not supported by arm-eabi or aarch64-elf targets for instance. You probably want to move the test to gcc.dg/goacc or add dg-require-effective-target fopenacc. Thanks, Christophe > Thanks, > Prathamesh > > > > Richard. > > > > > Thanks, > > > Prathamesh > > > > > > > > Thanks, > > > > Richard. > > > > > > > > > Thanks, > > > > > Prathamesh
