Hi Segher, on 2019/11/1 上午2:49, Segher Boessenkool wrote: > Hi! > > On Thu, Oct 31, 2019 at 05:35:22PM +0800, Kewen.Lin wrote: >>>> +/* Half VMX/VSX vector (for select) */ >>>> +VECTOR_MODE (FLOAT, SF, 2); /* V2SF */ >>>> +VECTOR_MODE (INT, SI, 2); /* V2SI */ >>> >>> Or "for internal use", in general. What happens if a user tries to create >>> something of such a mode? I hope we don't ICE :-/ >> >> I did some testings, it failed (ICE) if we constructed one insn with these >> modes artificially. But I also checked the existing V8SF/V8SI/V4DF/... etc., >> they have same issues. It looks more like a new issue to avoid that. > > What does "artificially" mean? If you had to change the compiler for your > test, that doesn't count; otherwise, please file a PR. >
Yes, I hacked the compiler to emit it directly. OK, it's fine then. :) >> * config/rs6000/vsx.md (UNSPEC_VSX_CVSPSXDS, UNSPEC_VSX_CVSPUXDS): >> Remove. > > (line too long) Will fix it. > > Okay for trunk. Thanks! > Thanks for your time! BR, Kewen
