On Mon, Oct 21, 2019 at 08:20:33AM -0700, Mike Stump wrote: > On Oct 21, 2019, at 3:30 AM, Segher Boessenkool <seg...@kernel.crashing.org> > wrote: > > > > On Sun, Oct 20, 2019 at 06:06:30PM +0200, Gerald Pfeifer wrote: > >> On Wed, 9 Oct 2019, js...@gcc.gnu.org wrote: > >>> +<li>Use "<code>git commit</code>" and "<code>git push origin > >>> +master</code>" to check in the patch.</li> > >> > >> I will admit I made a couple of first commits without reading those > >> details and just used a plain "git push". > >> > >> Is there any problem with that, any drawback? > >> > >> Or could we simplify those instructions? > > > > Neither command works in all cases > > This isn't helpful.
I was answering Gerald's question. I hope the answer was useful. I was not recommending either "git push" nor "git push origin master". Each has its drawbacks. That was my *point*. Either is fine in this doc, in my opinion. Segher
