On 10/17/19 3:12 PM, JeanHeyd Meneide wrote:
         * tree.c (handle_nodiscard_attribute): Implements p1301
           [[nodiscard("should have a reason")]].

This should be a heading at the top rather than specific to this file/function.

It looks like you didn't run the testsuite, I'm seeing several new failures:

> FAIL: g++.dg/cpp0x/gen-attrs-67.C  -std=c++11  (test for errors, line 8)
> FAIL: g++.dg/cpp1z/feat-cxx1z.C  -std=gnu++17 (test for excess errors)
> FAIL: g++.dg/cpp1z/nodiscard4.C  -std=c++11 (test for excess errors)
> FAIL: g++.dg/cpp1z/nodiscard4.C  -std=c++11  (test for warnings, line 12)
> FAIL: g++.dg/cpp1z/nodiscard4.C  -std=c++11  (test for warnings, line 13)
> FAIL: g++.dg/cpp2a/feat-cxx2a.C   (test for excess errors)

Jason

Reply via email to