On Tue, Oct 15, 2019 at 01:21:12PM +0200, Richard Biener wrote:
> On Tue, 15 Oct 2019, Kyrill Tkachov wrote:
>
> > Hi Richard,
> >
> > On 10/15/19 8:17 AM, Richard Biener wrote:
> > >
> > > This makes allow-store-data-races adjustable per function by making it
> > > a regular option rather than a --param.
> >
> >
> > Note that the kernel has --param=allow-store-data-races=0 in its build
> > flags.
> >
> > I guess that will break unless they rename it to
> > -fno-allow-store-data-races?
>
> Yes. Or simply drop the --param since unless they happen to use -Ofast
> their setting is the default.
I think nothing will break, because it is
KBUILD_CFLAGS += $(call cc-option,--param=allow-store-data-races=0)
and cc-option will expand to nothing if the --param is not supported
anymore. They can surely add
KBUILD_CFLAGS += $(call cc-option,-fno-allow-store-data-races)
but as Richard mentioned, if kernel isn't built with -Ofast, it should make
no difference.
Jakub
