Jiufu Guo <guoji...@linux.ibm.com> writes:
> Thanks for all your reviews and comments, very helpful! > > Peter Bergner <berg...@linux.ibm.com> writes: > >> I think we just need to fix the bug in the current logic when checking >> whether the caller's ISA flags supports the callee's ISA flags. ...and >> for that, I think we just need to add a test that enforces that the >> caller's ISA flags match exactly the callee's flags, for those flags >> that were explicitly set in the callee. The patch below seems to fix >> the issue (regtesting now). Does this look like what we want? > Great sugguestions, thanks again! > I was trying to figure out how to check 'explicitly disabled feature', > after checking your sugguestion deeperly. I notice that, > rs6000_isa_flags_explicit is set no matter a feature is > "explicitly disabled" or "explicitly enabled". > And to check a feature (e.g. VSX) is disabled explicitly, below code > could help: > (explicit_isa & VSX) && (callee_isa & explicit_isa & VSX == 0) typo, it should be: (explicit_isa & VSX) && (callee_isa & explicit_isa & VSX) == 0 > > This patch is indeed what I want. >> >> Peter >> >>
