On Mon, 14 Oct 2019 at 23:23, Jakub Jelinek <ja...@redhat.com> wrote: > > On Mon, Oct 14, 2019 at 03:24:02PM -0700, Prathamesh Kulkarni wrote: > > The patch fixes this by simply putting gsi_next in else, which avoids > > the above issue. > > Bootstrap+test in progress on x86_64-unknown-linux-gnu. > > OK to commit if passes ? > > No ChangeLog entry. > > --- a/gcc/tree-if-conv.c > +++ b/gcc/tree-if-conv.c > @@ -2976,7 +2976,8 @@ ifcvt_local_dce (class loop *loop) > if (dse_classify_store (&write, stmt, false, NULL, NULL, > latch_vdef) > == DSE_STORE_DEAD) > delete_dead_or_redundant_assignment (&gsi, "dead"); > - gsi_next (&gsi); > + else > + gsi_next (&gsi); > continue; > } > > The patch clearly shows that the 3 lines above it are incorrectly indented > (spaces instead of tabs), can you please fix that up while touching this? > > Ok for trunk with ChangeLog added and the indentation fixed. Thanks. Hi Jakub, Thanks for the approval. I committed the patch with indentation fixed (and ChangeLog) in r276984, after verifying it passes bootstrap+test on x86_64-unknown-linux-gnu.
Thanks, Prathamesh > > Jakub
