On 10/14/19 4:25 PM, Jason Merrill wrote:
The comment for get_formal_tmp_var says that it shouldn't be used for expressions whose value might change between initialization and use, and in this case we're creating a temporary precisely because the value might change, so we should use get_initialized_tmp_var instead. I also noticed that many callers of get_initialized_tmp_var pass NULL for post_p, so it seems appropriate to make it a default argument. OK for trunk?
BTW, a patch removing all those (now) unnecessary NULLs from get_initialized_tmp_var calls is pre-approved ;-).
What a pity that a lot of callers that pass NULL for post_p, pass FALSE for ssa, otherwise those could be cleaned up.
OK. Thanks. Aldy
