Hi, it was brought to my attention that my call to internal_error in the new IPA-SRA makes -Wformat-diag complain because it thinks that everything with an underscore is an identifier or a keyword and should be quoted. Well, the string should not contain "IPA_SRA" but "IPA-SRA" in the first place so this patch corrects that and hopefully the problem should go away. While at it I noticed that the %s in the same string should actually probably be quoted, so I'm replacing it with %qs too.
Bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin 2019-09-25 Martin Jambor <mjam...@suse.cz> * ipa-sra.c (verify_splitting_accesses): Fix quoting in a call to internal_error. --- gcc/ipa-sra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/ipa-sra.c b/gcc/ipa-sra.c index b35fff69472..50dee69e3db 100644 --- a/gcc/ipa-sra.c +++ b/gcc/ipa-sra.c @@ -2452,7 +2452,7 @@ verify_splitting_accesses (cgraph_node *node, bool certain_must_exist) bool certain_access_present = !certain_must_exist; if (overlapping_certain_accesses_p (desc, &certain_access_present)) - internal_error ("Function %s, parameter %u, has IPA_SRA accesses " + internal_error ("Function %qs, parameter %u, has IPA-SRA accesses " "which overlap", node->dump_name (), pidx); if (!certain_access_present) internal_error ("Function %s, parameter %u, is used but does not " -- 2.23.0