Hi Bernd,
On 8/15/19 8:47 PM, Bernd Edlinger wrote:
Hi,
this is the split out part from the "Fix not 8-byte aligned ldrd/strd on ARMv5 (PR
89544)"
which is sanitizing the middle-end interface to the back-end for strict
alignment,
and a couple of bug-fixes that are necessary to survive boot-strap.
It is intended to be applied after the PR 89544 fix.
I think it would be possible to change the default implementation of
STACK_SLOT_ALIGNMENT
to make all stack variables always naturally aligned instead of doing that only
in assign_parm_setup_stack, but would still like to avoid changing too many
things
that do not seem to have a problem. Since this would affect many targets, and
more
kinds of variables that may probably not have a strict alignment problem.
But I am ready to take your advice though.
Boot-strapped and reg-tested on x86_64-pc-linux-gnu and arm-linux-gnueabihf
Is it OK for trunk?
I'm not opposed to the checks but...
Thanks
Bernd.
Index: gcc/config/arm/arm.md
===================================================================
--- gcc/config/arm/arm.md (Revision 274531)
+++ gcc/config/arm/arm.md (Arbeitskopie)
@@ -5838,6 +5838,12 @@
(match_operand:DI 1 "general_operand"))]
"TARGET_EITHER"
"
+ gcc_checking_assert (!MEM_P (operands[0])
+ || MEM_ALIGN (operands[0])
+ >= GET_MODE_ALIGNMENT (DImode));
+ gcc_checking_assert (!MEM_P (operands[1])
+ || MEM_ALIGN (operands[1])
+ >= GET_MODE_ALIGNMENT (DImode));
if (can_create_pseudo_p ())
{
if (!REG_P (operands[0]))
@@ -6014,6 +6020,12 @@
{
rtx base, offset, tmp;
+ gcc_checking_assert (!MEM_P (operands[0])
+ || MEM_ALIGN (operands[0])
+ >= GET_MODE_ALIGNMENT (SImode));
+ gcc_checking_assert (!MEM_P (operands[1])
+ || MEM_ALIGN (operands[1])
+ >= GET_MODE_ALIGNMENT (SImode));
if (TARGET_32BIT || TARGET_HAVE_MOVT)
{
/* Everything except mem = const or mem = mem can be done easily. */
@@ -6503,6 +6515,12 @@
(match_operand:HI 1 "general_operand"))]
"TARGET_EITHER"
"
+ gcc_checking_assert (!MEM_P (operands[0])
+ || MEM_ALIGN (operands[0])
+ >= GET_MODE_ALIGNMENT (HImode));
+ gcc_checking_assert (!MEM_P (operands[1])
+ || MEM_ALIGN (operands[1])
+ >= GET_MODE_ALIGNMENT (HImode));
if (TARGET_ARM)
{
if (can_create_pseudo_p ())
@@ -6912,6 +6930,12 @@
(match_operand:HF 1 "general_operand"))]
"TARGET_EITHER"
"
+ gcc_checking_assert (!MEM_P (operands[0])
+ || MEM_ALIGN (operands[0])
+ >= GET_MODE_ALIGNMENT (HFmode));
+ gcc_checking_assert (!MEM_P (operands[1])
+ || MEM_ALIGN (operands[1])
+ >= GET_MODE_ALIGNMENT (HFmode));
if (TARGET_32BIT)
{
if (MEM_P (operands[0]))
@@ -6976,6 +7000,12 @@
(match_operand:SF 1 "general_operand"))]
"TARGET_EITHER"
"
+ gcc_checking_assert (!MEM_P (operands[0])
+ || MEM_ALIGN (operands[0])
+ >= GET_MODE_ALIGNMENT (SFmode));
+ gcc_checking_assert (!MEM_P (operands[1])
+ || MEM_ALIGN (operands[1])
+ >= GET_MODE_ALIGNMENT (SFmode));
if (TARGET_32BIT)
{
if (MEM_P (operands[0]))
@@ -7071,6 +7101,12 @@
(match_operand:DF 1 "general_operand"))]
"TARGET_EITHER"
"
+ gcc_checking_assert (!MEM_P (operands[0])
+ || MEM_ALIGN (operands[0])
+ >= GET_MODE_ALIGNMENT (DFmode));
+ gcc_checking_assert (!MEM_P (operands[1])
+ || MEM_ALIGN (operands[1])
+ >= GET_MODE_ALIGNMENT (DFmode));
if (TARGET_32BIT)
{
if (MEM_P (operands[0]))
Index: gcc/config/arm/neon.md
===================================================================
--- gcc/config/arm/neon.md (Revision 274531)
+++ gcc/config/arm/neon.md (Arbeitskopie)
@@ -127,6 +127,12 @@
(match_operand:TI 1 "general_operand"))]
"TARGET_NEON"
{
+ gcc_checking_assert (!MEM_P (operands[0])
+ || MEM_ALIGN (operands[0])
+ >= GET_MODE_ALIGNMENT (TImode));
+ gcc_checking_assert (!MEM_P (operands[1])
+ || MEM_ALIGN (operands[1])
+ >= GET_MODE_ALIGNMENT (TImode));
if (can_create_pseudo_p ())
{
if (!REG_P (operands[0]))
@@ -139,6 +145,12 @@
(match_operand:VSTRUCT 1 "general_operand"))]
"TARGET_NEON"
{
+ gcc_checking_assert (!MEM_P (operands[0])
+ || MEM_ALIGN (operands[0])
+ >= GET_MODE_ALIGNMENT (<MODE>mode));
+ gcc_checking_assert (!MEM_P (operands[1])
+ || MEM_ALIGN (operands[1])
+ >= GET_MODE_ALIGNMENT (<MODE>mode));
if (can_create_pseudo_p ())
{
if (!REG_P (operands[0]))
@@ -151,6 +163,12 @@
(match_operand:VH 1 "s_register_operand"))]
"TARGET_NEON"
{
+ gcc_checking_assert (!MEM_P (operands[0])
+ || MEM_ALIGN (operands[0])
+ >= GET_MODE_ALIGNMENT (<MODE>mode));
+ gcc_checking_assert (!MEM_P (operands[1])
+ || MEM_ALIGN (operands[1])
+ >= GET_MODE_ALIGNMENT (<MODE>mode));
if (can_create_pseudo_p ())
{
if (!REG_P (operands[0]))
Index: gcc/config/arm/vec-common.md
===================================================================
--- gcc/config/arm/vec-common.md (Revision 274531)
+++ gcc/config/arm/vec-common.md (Arbeitskopie)
@@ -26,6 +26,12 @@
"TARGET_NEON
|| (TARGET_REALLY_IWMMXT && VALID_IWMMXT_REG_MODE (<MODE>mode))"
{
+ gcc_checking_assert (!MEM_P (operands[0])
+ || MEM_ALIGN (operands[0])
+ >= GET_MODE_ALIGNMENT (<MODE>mode));
+ gcc_checking_assert (!MEM_P (operands[1])
+ || MEM_ALIGN (operands[1])
+ >= GET_MODE_ALIGNMENT (<MODE>mode));
if (can_create_pseudo_p ())
{
if (!REG_P (operands[0]))
... can we please factor the (!MEM_P (operands[0]) || MEM_ALIGN (operands[0]) >=
GET_MODE_ALIGNMENT (<MODE>mode)) checks into a common function and use that?
Thanks,
Kyrill
