On Wed, 21 Aug 2019, Martin Jambor wrote: > Hi Tejas, > > On Wed, Aug 14 2019, Tejas Joshi wrote: > > Hi. > > Here is a clean patch that does not fold roundeven resulting for > > integer type and the conditions for folding functions > > round/ceil/floor/roundeven and trunc only checks for signaling NaN. > > wouldn't checking for *signalling* NaNs mean using the macro > REAL_VALUE_ISSIGNALING_NAN rather than REAL_VALUE_ISNAN?
Yes, it would. So the patch should be retested / reposted with that change. > > \ No newline at end of file This should be fixed (in both places, the tests should each end with exactly one newline character). The new built-in functions roundeven / roundevenf / roundevenl also need to be added to the lists in extend.texi (the list of GNU extension functions for now, though once we add DEF_C2X_BUILTIN they'd go in a list of C2X built-in functions instead). -- Joseph S. Myers jos...@codesourcery.com