On Mon, 8 Jul 2019, Martin Liška wrote:
The patch apparently has DECL_IS_OPERATOR_DELETE only on the
replaceable global deallocation functions, not all delete operators,
contrary to DECL_IS_OPERATOR_NEW, so the name is misleading. On the
other hand, those seem to be the ones for which the optimization is
legal (well, not quite, the rules are in terms of operator new, and I
am not sure how well operator delete has to match, but close enough).
Are you talking about this location where we set OPERATOR_NEW:
https://github.com/gcc-mirror/gcc/blob/master/gcc/cp/decl.c#L13643
?
That's the only place where we set OPERATOR_NEW flag and not OPERATOR_DELETE.
Yes, I think that's the place.
Again, not setting DECL_IS_OPERATOR_DELETE on local operator delete
seems misleading, but setting it would let us optimize in cases where we
are not really allowed to. Maybe just rename your macro to
DECL_IS_GLOBAL_OPERATOR_DELETE?
--
Marc Glisse
