On 11/21/2011 06:06 AM, Rainer Orth wrote:
> * libitm.so wasn't versioned even with gld, since libitm_la_LDFLAGS
>   wasn't passed when linking it.

foo_LDFLAGS is supposed to be one of those auto variables that gets used when 
linking foo.  I know that the library was successfully versioned when I put all 
that stuff in on the branch...  But, whatever, autotomfoolery is disgustingly 
fragile.

> * _ITM_getThreadnum is the only symbol in libitm.map that isn't present
>   in the library.  It's documented as missing and should perhaps be
>   removed from the map?

Probably.

>       libitm:
>       * acinclude.m4 (LIBITM_CHECK_LINKER_FEATURES): Handle gold.
>       (LIBITM_ENABLE_SYMVERS): Handle sun style.
>       * Makefile.am: Handle sun style versioning.
>       (libitm_la_LINK): Add $(libitm_la_LDFLAGS).
>       * configure: Regenerate.
>       * Makefile.in: Regenerate.
> 
>       contrib:
>       * make_sunver.pl: Convert '?' in glob patterns to '.'.

Ok.


r~

Reply via email to