On Sat, Jun 22, 2019 at 11:28:36PM -0400, Jason Merrill wrote: > On 6/13/19 5:03 PM, Marek Polacek wrote: > > Case values are converted constant expressions, so narrowing conversion is > > not > > permitted. This patch adds detecting narrowing to case_conversion; it's a > > handy spot because we have both the value and the (adjusted) type of the > > condition. > > Is there a reason not to use build_converted_constant_expr?
The function comment says "Note that if TYPE and VALUE are already integral we don't really do the conversion because the language-independent warning/optimization code will work better that way" so I avoided adding any conversions. What I could do is to, instead of calling check_narrowing, call build_converted_constant_expr (type, value, tf_warning_or_error); and not use its result, but I'm not sure what the benefits would be. I can retest the patch with that change, if you want. -- Marek Polacek • Red Hat, Inc. • 300 A St, Boston, MA
