Hi Silvia,

> Combined them into one pattern. Updated the diff and the changelog is now:
 
 gcc/ChangeLog:
 
 2019-06-18  Sylvia Taylor  <sylvia.tay...@arm.com>
 
         * config/aarch64/aarch64.c
         (aarch64_load_symref_appropriately): Change SYMBOL_TINY_GOT.
         * config/aarch64/aarch64.md
         (ldr_got_tiny_<mode>): New pattern.
         (ldr_got_tiny_sidi): New pattern.
 

Thanks, this looks fine to me, but I can't approve. 

As an aside there is an inconsistency in the mode used for symbols throughout
aarch64.md. Some have no mode, others use PTR, and some cases use DI mode
(which means ILP32 may want SImode for some symbols and DImode in other 
cases...).
Since various existing patterns have this issue it's not a problem with this 
patch.

Wilco
     

Reply via email to