On 6/26/19 2:16 PM, Aaron Sawdey wrote: > On 6/25/19 4:43 PM, Jeff Law wrote: >> On 6/25/19 2:22 PM, acsaw...@linux.ibm.com wrote: >>> From: Aaron Sawdey <acsaw...@linux.ibm.com> >>> >>> * builtins.c (get_memory_rtx): Fix comment. >>> * optabs.def (movmem_optab): Change to cpymem_optab. >>> * expr.c (emit_block_move_via_cpymem): Change movmem to cpymem. >>> (emit_block_move_hints): Change movmem to cpymem. >>> * defaults.h: Change movmem to cpymem. >>> * targhooks.c (get_move_ratio): Change movmem to cpymem. >>> (default_use_by_pieces_infrastructure_p): Ditto. >> So I think you're missing an update to the RTL/MD documentation. This >> is also likely to cause problems for any out-of-tree ports, so it's >> probably worth a mention in the gcc-10 changes, which will need to be >> created (in CVS no less, ugh). >> >> I think the stuff posted to-date is fine, but it shouldn't go in without >> the corresponding docs and gcc-10 changes updates. > This would be my proposed patch to update the documentation. I'll also work > out what the entry in the gcc 10 changes and post that for review before > this all goes in. > > OK for trunk along with the other 30 patches? > > Thanks, > Aaron > > > > * doc/md.texi: Change movmem to cpymem and update description to match. > * doc/rtl.texi: Change movmem to cpymem. > * target.def (use_by_pieces_infrastructure_p): Change movmem to cpymem. > * doc/tm.texi: Regenerate. OK. The entire kit is OK for the trunk now.
jeff