On 6/19/19 2:26 PM, Giuliano Belinassi wrote:
> On 06/19, Jeff Law wrote:
>> On 1/24/19 12:51 PM, Giuliano Belinassi wrote:
>>> This patch adds two variables named 'TV_CGRAPH_FUNC_EXPANSION' and
>>> 'TV_CGRAPH_IPA_PASSES' that count the elapsed time of the functions
>>> 'expand_all_functions' and 'ipa_passes', respectivelly.
>>>
>>> The main point of this is that these functions takes a very long time
>>> when compiling the 'gimple-match.c' file, and therefore may also take
>>> a long time when compiling other large files.
>>>
>>> I also accept suggestions about how to improve this :-)
>>>
>>> ChangeLog:
>>>
>>> 2019-01-24 Giuliano Belinassi <giuliano.belina...@usp.br>
>>>
>>> * cgraph_unit.c (compile): TV_CGRAPH_FUNC_EXPANSION and
>>> TV_CGRAPH_IPA_PASSES start, stop.
>>> * timevar.def (TV_CGRAPH_IPA_PASSES, TV_CGRAPH_FUNC_EXPANSION): New.
>> So I'm guessing you want the accumulated time for the ipa_passes and
>> expansion. So independent counters using timevar_{start,stop} seem right.
>
> Yes, my point was to accumulate the total time spent in those function,
> including everything these functions calls.
OK. Then let's go with your patch as-is if you'd still like it included
on the trunk.
>
> With regard to breaking the timevar with IPA, GIMPLE and RTL expansion
> passes, I can do this but it will require splitting `all_passes` into
> `all_passes` and `all_rtl_passes`, as suggested by richi in the
> parallelization thread. I can do this fairly easily since I have
> already done it done in my branch. Is it OK?
I think that'll be fine when you're ready to merge from your branch to
the trunk.
jeff
