Hi,

On Thu, May 23, 2019 at 04:15:26PM -0500, Bill Schmidt wrote:
> This is a short patch that enables PC-relative support by default, and 
> provides a
> test case to ensure that the correct .localentry name,1 directive is produced 
> iff
> PC-relative support is enabled.

> 2019-05-23  Bill Schmidt  <wschm...@linux.ibm.com>
> 
>       * gcc.target/powerpc/pcrel-detect-1.c: New file.

That's a very strange file name for what it tests, then.  Improve it?

> diff --git a/gcc/testsuite/gcc.target/powerpc/pcrel-detect-1.c 
> b/gcc/testsuite/gcc.target/powerpc/pcrel-detect-1.c
> new file mode 100644
> index 00000000000..8e0e9053dc7
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/powerpc/pcrel-detect-1.c
> @@ -0,0 +1,12 @@
> +/* { dg-do compile { target { powerpc*-*-* } } } */

Just

/* { dg-do compile } */

is enough.

> +/* { dg-require-effective-target powerpc_elfv2 } */
> +/* { dg-options "-O3 -mdejagnu-cpu=future" } */

Please use -O2 if there is not specific reason for -O3.

Okay with those things fixed somehow.  Thanks,


Segher

Reply via email to