在 2019/5/13 下午5:02, Jakub Jelinek 写道:
On Mon, May 13, 2019 at 04:53:52PM +0800, JunMa wrote:
According to gnu document of function attributes, neither weakref nor
alias
could be attached to a function defined in current translation unit.
Although GCC checks the attributes under some circumstances, it still
fails
on some cases and even causes ICE.

This patch checks whether alias/weakref attribute attaches on a function
declaration which has body, and removes the attribute later.
This also avoid the ICE.

Bootstrapped/regtested on x86_64-linux, ok for GCC10?

2019-03-26  Jun Ma <ju...@linux.alibaba.com>

     PR89341
     * cgraphunit.c (handle_alias_pairs): Check whether alias attribute
attaches
     on a function declaration which has body.

gcc/testsuite/ChangeLog

2019-03-26  Jun Ma <ju...@linux.alibaba.com>

     PR89341
     * gcc.dg/attr-alias-6.c: New test.
     * gcc.dg/attr-weakref-5.c: Likewise.
Hi Jakub

   Since you are owner of this part, so I add you to cc list.
   Ping?
I'm not the maintainer of the callgraph, Honza is:
callgraph               Jan Hubicka             <hubi...@ucw.cz>
Hi Jakub

    Thanks for your reminder.
    Honza, Ping?

Regards
JunMa
        Jakub


Reply via email to