noted, thanks :) Best, Nina
On Sun, 28 Apr 2019 at 22:46, Jonathan Wakely <jwak...@redhat.com> wrote: > > On 28/04/19 22:44 +0100, Jonathan Wakely wrote: > >On 29/04/19 00:18 +0300, Ville Voutilainen wrote: > >>On Wed, 24 Apr 2019 at 14:53, Jonathan Wakely <jwak...@redhat.com> wrote: > >>> > >>>On 24/04/19 11:21 +0100, Nina Dinka Ranns wrote: > >>>>New diff attached. > >>> > >>>Thanks, this looks great. I think we can apply this as soon as stage 1 > >>>begins (which should be Real Soon Now). > >> > >>Tested on Linux-PPC64, committed to trunk. Congrats, Nina, first patch > >>in, let there be many more. :) > > > >Thanks, Nina, and Ville for taking care of the commit. > > > >Apologies for not noticing it earlier, but the first line of the > >ChangeLog entry was not formatted correctly. There should be two > >spaces either side of the author's name: > > > >2019-04-28 John Doe <j...@example.com> > > > >not: > > > >2019-04-28 John Doe <j...@example.com> > > > >I've committed r270633 to fix it. > > > >Thanks again. > > Oh, and the files in the ChangeLog entry should use paths relative to > the ChangeLog file, so no libstdc++-v3/ prefixes. I missed that in the > review too. > >
