On Thu, Apr 25, 2019 at 7:52 PM James Clarke <jrt...@jrtc27.com> wrote: > > By using ASM_OUTPUT_LABEL, r257511 forced the assembler to start a new > bundle when emitting an inline entry label on. Instead, use > ASM_OUTPUT_DEBUG_LABEL like for the block begin and end labels so tags are > emitted rather than labels.
Looks sensible. mips is the other port defining ASM_OUTPUT_DEBUG_LABEL, so either you can do a bootstrap/test on mips as well or I'm asking Matthew for approval here. I'd say OK for trunk (GCC 10) and if things look good backport later to active branches. Thanks, Richard. > gcc/ > PR bootstrap/87338 > * dwarf2out.c (dwarf2out_inline_entry): Use ASM_OUTPUT_DEBUG_LABEL > instead of ASM_GENERATE_INTERNAL_LABEL and ASM_OUTPUT_LABEL. > --- > gcc/dwarf2out.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c > index b9a624e..c348692 100644 > --- a/gcc/dwarf2out.c > +++ b/gcc/dwarf2out.c > @@ -27670,11 +27670,8 @@ dwarf2out_inline_entry (tree block) > if (cur_line_info_table) > ied->view = cur_line_info_table->view; > > - char label[MAX_ARTIFICIAL_LABEL_BYTES]; > - > - ASM_GENERATE_INTERNAL_LABEL (label, BLOCK_INLINE_ENTRY_LABEL, > - BLOCK_NUMBER (block)); > - ASM_OUTPUT_LABEL (asm_out_file, label); > + ASM_OUTPUT_DEBUG_LABEL (asm_out_file, BLOCK_INLINE_ENTRY_LABEL, > + BLOCK_NUMBER (block)); > } > > /* Called from finalize_size_functions for size functions so that their body > -- > 1.8.5.3 >
